ruanwenjun commented on issue #10305:
URL:
https://github.com/apache/dolphinscheduler/issues/10305#issuecomment-1141656804
> > @guodongym I suggest that we can remove these three constant in and keep
in .`` org.apache.dolphinscheduler.common.Constants
``org.apache.dolphinscheduler.plugin.task.api.TaskConstants ``
>
> ## @ruanwenjun I think the opposite, Can keep in
`org.apache.dolphinscheduler.common.Constants` , remove that from
`org.apache.dolphinscheduler.plugin.task.api.TaskConstants` , Because these
parameters should be global as more AWS components are supported
> 我认为恰恰相反，因为随着后续支持更多的AWS组件，这三个参数应该是全局通用的，不应该保持在task的常量里面
In my knowledge, AWS is just a choosable plugin, it should not be a
necessary dependency. Put the module-specific
parameters into specific modules will be more cohesive.
BTW, `dolphinscheduler-common` rely on `task-api`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
