ruanwenjun commented on code in PR #10360:
URL: https://github.com/apache/dolphinscheduler/pull/10360#discussion_r889496136
##########
dolphinscheduler-service/pom.xml:
##########
@@ -52,14 +52,8 @@
</dependency>
<dependency>
- <groupId>org.springframework.boot</groupId>
- <artifactId>spring-boot-starter-quartz</artifactId>
- <exclusions>
- <exclusion>
- <groupId>org.springframework.boot</groupId>
- <artifactId>spring-boot-starter</artifactId>
- </exclusion>
- </exclusions>
+ <groupId>com.cronutils</groupId>
+ <artifactId>cron-utils</artifactId>
</dependency>
<dependency>
<groupId>org.quartz-scheduler</groupId>
Review Comment:
Right now, we have some class rely on the quartz module to do some cron
parsing. We need to refactor the CronUtils, then we can remove the
`org.quartz-scheduler ` module. I add a `todo` in `CronUtils`, it will take
some to refactor this util.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
