SbloodyS commented on code in PR #10376:
URL: https://github.com/apache/dolphinscheduler/pull/10376#discussion_r893037788
##########
dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteThread.java:
##########
@@ -943,15 +938,12 @@ private void initTaskQueue() {
if (processInstance.isComplementData() && complementListDate.size() ==
0) {
Map<String, String> cmdParam =
JSONUtils.toMap(processInstance.getCommandParam());
- if (cmdParam != null &&
cmdParam.containsKey(CMDPARAM_COMPLEMENT_DATA_START_DATE)) {
+ if (cmdParam != null &&
cmdParam.containsKey(CMDPARAM_COMPLEMENT_DATA_SCHEDULE_DATE)) {
// reset global params while there are start parameters
setGlobalParamIfCommanded(processDefinition, cmdParam);
- Date start =
DateUtils.stringToDate(cmdParam.get(CMDPARAM_COMPLEMENT_DATA_START_DATE));
- Date end =
DateUtils.stringToDate(cmdParam.get(CMDPARAM_COMPLEMENT_DATA_END_DATE));
- List<Schedule> schedules =
processService.queryReleaseSchedulerListByProcessDefinitionCode(processInstance.getProcessDefinitionCode());
if (complementListDate.size() == 0 && needComplementProcess())
{
- complementListDate = CronUtils.getSelfFireDateList(start,
end, schedules);
Review Comment:
As we discuss in wechat. I do not think this is a good idea to remove such a
big feature of complement data.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
