kezhenxu94 commented on code in PR #10373:
URL: https://github.com/apache/dolphinscheduler/pull/10373#discussion_r893038864
##########
dolphinscheduler-task-plugin/dolphinscheduler-task-api/src/main/java/org/apache/dolphinscheduler/plugin/task/api/utils/OSUtils.java:
##########
@@ -68,6 +69,15 @@ public static boolean isWindows() {
return getOSName().startsWith("Windows");
}
+ /**
+ * whether is linux
+ *
+ * @return true if linux
+ */
+ public static boolean isLinux() {
+ return SystemUtils.IS_OS_LINUX;
+ }
Review Comment:
Can you replace (in another PR) all these `isXxx` with `common.lang3` and
inline these methods? Instead of wrapping them again in a method
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
