ruanwenjun commented on code in PR #10383:
URL: https://github.com/apache/dolphinscheduler/pull/10383#discussion_r894098891
##########
dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/consumer/TaskPriorityQueueConsumer.java:
##########
@@ -157,11 +154,15 @@ public List<TaskPriority> batchDispatch(int fetchTaskNum)
throws TaskPriorityQue
}
consumerThreadPoolExecutor.submit(() -> {
- boolean dispatchResult = this.dispatchTask(taskPriority);
- if (!dispatchResult) {
- failedDispatchTasks.add(taskPriority);
+ try {
+ boolean dispatchResult = this.dispatchTask(taskPriority);
+ if (!dispatchResult) {
+ failedDispatchTasks.add(taskPriority);
+ }
+ } finally {
Review Comment:
But here is not checked exception will be thrown here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
