mgsky1 opened a new pull request, #10397: URL: https://github.com/apache/dolphinscheduler/pull/10397
<!--Thanks very much for contributing to Apache DolphinScheduler. Please review https://dolphinscheduler.apache.org/en-us/community/development/pull-request.html before opening a pull request.--> ## Purpose of the pull request <!--(For example: This pull request adds checkstyle plugin).--> This PR adds blocking task UI and documentation. The blocking task node backed code has been merged in PR [#6272](https://github.com/apache/dolphinscheduler/pull/6272). ## Brief change log <!--*(for example:)* - *Add maven-checkstyle-plugin to root pom.xml* --> - add blocking task icon - add blocking task configuration pannel - add operations (continue or re-run) when the workflow has been blocked - add blocking task documentation in Chinese and English ## Screen Shots     ## Verify this pull request Test cases: - normal: i.e. Blocking node has upstream and downstram nodes. - blocking node in the begining of workflow. - blocking node in the end of workflow. They all work fine. ## Discuss - When config blocking node, it has a alert option. In my view, it is better to use switch plugin, but I do not know how to set switch plugin value when the switch turning on or off. - As for the operation after the workflow is blocked. I think re-run and continue execution is rational. When I testing the operation: continuing from faild node, this operation will skip those node which has been executed successfully. It means that blocking node will lose its function. So I disable this operation. --- ## 此PR的目的 为了完善阻断类任务的开发，后端代码已经在PR[#6272](https://github.com/apache/dolphinscheduler/pull/6272)中被合并 ## 变更日志 - 阻断类任务图标 - 阻断节点配置面板 - 当工作流被阻断时，提供重跑和继续执行，两种选择 - 增加阻断节点中英文档 ## 截图     ## 测试 主要测试了以下几种情况 - 正常模式：阻断节点上下游都有任务 - 阻断节点在工作流头部（没有上游节点） - 阻断节点在工作流尾部（没有下游节点） 它们都能正常工作 ## 讨论 - 在阻断节点的配置中，有一个告警选项，我觉得将其作为switch开关更合适，但是我不知道如何给这个switch开关赋值，从代码来看，新的ui将配置项的每一条都抽出进行了高度封装，返回`IJsonItem`数组，不知道这种场景下，要用`IJsonItem`的什么字段给开关赋值。从现有的代码参考看，如果是在节点配置面板中使用了switch开关，那么开启开关后，会弹出更详细的设置信息；另外一处是在工作流空跑时出现的，那个场景是直接用HTML标签搞定的。 - 对于工作流被阻断后的操作，我觉得继续执行和重跑是合理的。对于重新执行失败节点，在测试中发现，这种模式会跳过已经执行成功的节点，这会导致阻断节点的失效，因此不启用。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
