SbloodyS commented on code in PR #10376:
URL: https://github.com/apache/dolphinscheduler/pull/10376#discussion_r894184453
##########
dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/corn/CronUtils.java:
##########
@@ -35,13 +34,9 @@
import org.apache.commons.collections.CollectionUtils;
import java.text.ParseException;
-import java.util.ArrayList;
-import java.util.Calendar;
-import java.util.Collections;
-import java.util.Date;
-import java.util.GregorianCalendar;
-import java.util.List;
+import java.util.*;
Review Comment:
This has not been addressed.
##########
dolphinscheduler-e2e/dolphinscheduler-e2e-case/src/test/java/org/apache/dolphinscheduler/e2e/cases/WorkflowE2ETest.java:
##########
@@ -162,56 +162,56 @@ void testCreateSubWorkflow() {
workflowDefinitionPage.publish(workflow);
}
- @Test
- @Order(30)
- void testRunWorkflow() {
- final String workflow = "test-workflow-1";
- final ProjectDetailPage projectPage =
- new ProjectPage(browser)
- .goToNav(ProjectPage.class)
- .goTo(project);
-
- projectPage
- .goToTab(WorkflowInstanceTab.class)
- .deleteAll();
- projectPage
- .goToTab(WorkflowDefinitionTab.class)
- .run(workflow)
- .submit();
-
- await().untilAsserted(() -> {
- browser.navigate().refresh();
-
- final Row row = projectPage
- .goToTab(WorkflowInstanceTab.class)
- .instances()
- .iterator()
- .next();
-
- assertThat(row.isSuccess()).isTrue();
- assertThat(row.executionTime()).isEqualTo(1);
- });
- // Test rerun
- projectPage
- .goToTab(WorkflowInstanceTab.class)
- .instances()
- .stream()
- .filter(it -> it.rerunButton().isDisplayed())
- .iterator()
- .next()
- .rerun();
-
- await().untilAsserted(() -> {
- browser.navigate().refresh();
-
- final Row row = projectPage
- .goToTab(WorkflowInstanceTab.class)
- .instances()
- .iterator()
- .next();
-
- assertThat(row.isSuccess()).isTrue();
- assertThat(row.executionTime()).isEqualTo(2);
- });
- }
+// @Test
+// @Order(30)
+// void testRunWorkflow() {
+// final String workflow = "test-workflow-1";
+// final ProjectDetailPage projectPage =
+// new ProjectPage(browser)
+// .goToNav(ProjectPage.class)
+// .goTo(project);
+//
+// projectPage
+// .goToTab(WorkflowInstanceTab.class)
+// .deleteAll();
+// projectPage
+// .goToTab(WorkflowDefinitionTab.class)
+// .run(workflow)
+// .submit();
+//
+// await().untilAsserted(() -> {
+// browser.navigate().refresh();
+//
+// final Row row = projectPage
+// .goToTab(WorkflowInstanceTab.class)
+// .instances()
+// .iterator()
+// .next();
+//
+// assertThat(row.isSuccess()).isTrue();
+// assertThat(row.executionTime()).isEqualTo(1);
+// });
+// // Test rerun
+// projectPage
+// .goToTab(WorkflowInstanceTab.class)
+// .instances()
+// .stream()
+// .filter(it -> it.rerunButton().isDisplayed())
+// .iterator()
+// .next()
+// .rerun();
+//
+// await().untilAsserted(() -> {
+// browser.navigate().refresh();
+//
+// final Row row = projectPage
+// .goToTab(WorkflowInstanceTab.class)
+// .instances()
+// .iterator()
+// .next();
+//
+// assertThat(row.isSuccess()).isTrue();
+// assertThat(row.executionTime()).isEqualTo(2);
+// });
+// }
Review Comment:
Why did you comment out this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
