zhongjiajie commented on code in PR #10337:
URL: https://github.com/apache/dolphinscheduler/pull/10337#discussion_r896861533
##########
dolphinscheduler-task-plugin/dolphinscheduler-task-jupyter/src/main/java/org/apache/dolphinscheduler/plugin/task/jupyter/JupyterConstants.java:
##########
@@ -33,6 +33,18 @@ private JupyterConstants() {
*/
public static final String CONDA_ACTIVATE = "conda activate";
+ /**
+ * create and activate conda env from tar
+ */
+ public static final String CREATE_ENV_FROM_TAR = "mkdir jupyter_env && " +
+ "tar -xzf %s -C jupyter_env && " +
+ "source jupyter_env/bin/activate";
Review Comment:
> However, I think it is a good idea to give a choice to define the path and
install the env on workers without getting removed after task execution. In
this way, the same env will not need to be downloaded every time.
but I do not think so, I think they can use shell task to do that. It is odd
if we do not remove resources after the task execute finish, using two cases:
* we only support not deleting resources after task is done: although the
worker has already installed the env, but we still have resource configurated
in task definition, So it means worker will re-install the conda env to worker.
Or maybe users have to change the task definition and remove the resource after
the first time they ran the task.(it is odd)
* We have given users an option about resources install and delete. then
have to change the option after they ran the task first time too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
