tongwl commented on code in PR #10096: URL: https://github.com/apache/dolphinscheduler/pull/10096#discussion_r897495362
########## dolphinscheduler-ui/src/views/security/cluster-manage/index.tsx: ########## @@ -0,0 +1,170 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +import { defineComponent, onMounted, toRefs, watch } from 'vue' +import { + NButton, + NCard, + NDataTable, + NIcon, + NInput, + NPagination +} from 'naive-ui' +import { SearchOutlined } from '@vicons/antd' +import { useI18n } from 'vue-i18n' +import { useTable } from './use-table' +import Card from '@/components/card' +import ClusterModal from './components/cluster-modal' +import styles from './index.module.scss' + +const clusterManage = defineComponent({ + name: 'cluster-manage', + setup() { + const { t } = useI18n() + const { variables, getTableData, createColumns } = useTable() + + const requestData = () => { + getTableData({ + pageSize: variables.pageSize, + pageNo: variables.page, + searchVal: variables.searchVal + }) + } + + const onUpdatePageSize = () => { + variables.page = 1 + requestData() + } + + const onSearch = () => { + variables.page = 1 + requestData() + } + + const handleModalChange = () => { + variables.showModalRef = true + variables.statusRef = 0 + } + + const onCancelModal = () => { + variables.showModalRef = false + } + + const onConfirmModal = () => { + variables.showModalRef = false + requestData() + } + + onMounted(() => { + createColumns(variables) + requestData() + }) + + watch(useI18n().locale, () => { + createColumns(variables) + }) + + return { + t, + ...toRefs(variables), + requestData, + onCancelModal, + onConfirmModal, + onUpdatePageSize, + handleModalChange, + onSearch + } + }, + render() { + const { + t, + requestData, + onUpdatePageSize, + onCancelModal, + onConfirmModal, + handleModalChange, + onSearch, + loadingRef + } = this + + return ( + <div> + <NCard> + <div class={styles['search-card']}> + <div> + <NButton + size='small' + type='primary' + onClick={handleModalChange} + class='btn-create-cluster' + > + {t('security.cluster.create_cluster')} + </NButton> + </div> + <div class={styles.box}> + <NInput + size='small' + clearable + v-model={[this.searchVal, 'value']} + placeholder={t('security.cluster.search_tips')} + /> + <NButton size='small' type='primary' onClick={onSearch}> + {{ + icon: () => ( + <NIcon> + <SearchOutlined /> + </NIcon> + ) + }} + </NButton> + </div> + </div> Review Comment: Hi @Amy0104, yes, you are right, for this part, I have changed the code with NSpace(without css), it's better use NSpace. And about the next comments, lines near 155, as the parent div also has margin-top, not only keep NPagination center, so I kept the same code(<div class={styles.pagination}>) with other pages, because they have implemented the unified css margin-top in css file -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
