SbloodyS commented on PR #10442: URL: https://github.com/apache/dolphinscheduler/pull/10442#issuecomment-1155954164
After a deep checking. I found the following differences in both core module's ```DolphinSchedulerExtension.java```. 1. The ```beforeAll``` and ```afterAll``` function would set ```webdriver``` and ``` browser``` in ```E2E-Test``` module. However, ```API-Test``` modules do not need these. 2. Based on the first point, there is no need to pull other additional containers in the ```API-Test``` module for local mode and non local mode. So there is no problem of distinguishing container images of M1 chip. As we can see, the implementation of the ```core``` module of the ```API-Test``` and ```E2E-Test``` is quite different. So if we want to combine these two modules into one. I think we need to create an abstract class. And then implement its own logic in the ```core``` of the two modules. I'm not sure whether we need to do this since it's not much different from now. WDYT? @zhongjiajie @kezhenxu94 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
