zhongjiajie commented on PR #10464: URL: https://github.com/apache/dolphinscheduler/pull/10464#issuecomment-1156397855
I wonder why this will not fail our tests, and go to see our SQL task tests. finally I find we just using the variable instead of constants. 🤣 @hiSandog please change https://github.com/apache/dolphinscheduler/blob/720a10a21e0dba54e08a5d7958eae5f8ca084d0d/dolphinscheduler-python/pydolphinscheduler/tests/tasks/test_sql.py#L141 this line from `SqlType.SELECT` to `"1"`, using the contants variable in uinttest is a bad choose -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
