ruanwenjun commented on code in PR #10479:
URL: https://github.com/apache/dolphinscheduler/pull/10479#discussion_r899002399
##########
dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/ProcessInstance.java:
##########
@@ -265,12 +265,13 @@ public ProcessInstance() {
*/
public ProcessInstance(ProcessDefinition processDefinition) {
this.processDefinition = processDefinition;
+ // todo: the name is not unique
Review Comment:
Right now, the `processInstanceName` is just used in front-end, we can
change the `DateUtils.getCurrentTimeStamp()` to the snowflake id, but I am not
sure if this is need to change, so I just add a todo in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
