EricGao888 commented on PR #10477: URL: https://github.com/apache/dolphinscheduler/pull/10477#issuecomment-1159901819
> > > Do we have a way to unify the formats of customize metrics as well as default metrics (like `jvm_gc_pause_seconds_max`, etc.)? Otherwise the defaults still don't follow the micrometer naming convention. > > > > > > @kezhenxu94 Thanks for pointing this out. Actually those default metrics DO follow the naming convention. If we check `http://ip:port/actuator/metrics`, we could get the list of metrics' names before mapping. We will see those default metrics as . The reason why in this PR it looks different is that this PR is still a draft and WIP. I haven't updated the docs yet. Sorry for the confusion. > > Nice if that's the case! LGTM @kezhenxu94 Somehow I just couldn't fall asleep last night. So I got up very early this morning, wrote some code and docs, committed and pushed them to find some peace and went to bed again. Haven't finished it yet, lol. I will complete this PR later today. :rofl: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
