zhuangchong commented on code in PR #10407: URL: https://github.com/apache/dolphinscheduler/pull/10407#discussion_r901435660
########## dolphinscheduler-task-plugin/dolphinscheduler-task-dvc/src/main/java/org/apache/dolphinscheduler/plugin/task/dvc/DvcParameters.java: ########## @@ -0,0 +1,106 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.dolphinscheduler.plugin.task.dvc; + +import org.apache.dolphinscheduler.plugin.task.api.parameters.AbstractParameters; + +import java.util.HashMap; + +public class DvcParameters extends AbstractParameters { + + /** + * common parameters + */ + + private String dvcTaskType; Review Comment: In fact, my suggestion is to use enumeration, you don't need to make any changes in the front end you write, use the enumeration class in the backend `TaskParamter` to receive `dvgTaskType` ``` private DvcTaskTypeEnum dvcTaskType ``` Whether it is developed according to the above, its impact is minimal. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
