[GitHub] [dolphinscheduler] someorz commented on a diff in pull request #10586: [Fix-9938][master] Fix 9938 query environment config set to task instance

Thu, 23 Jun 2022 20:48:49 -0700 


someorz commented on code in PR #10586:
URL: https://github.com/apache/dolphinscheduler/pull/10586#discussion_r905693687


##########
dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteRunnable.java:
##########
@@ -1115,6 +1115,12 @@ private TaskInstance findTaskIfExists(Long taskCode, int 
taskVersion) {
     private TaskInstance createTaskInstance(ProcessInstance processInstance, 
TaskNode taskNode) {
         TaskInstance taskInstance = findTaskIfExists(taskNode.getCode(), 
taskNode.getVersion());
         if (taskInstance != null) {
+            if (!taskInstance.getEnvironmentCode().equals(-1L)) {
+                Environment environment = 
processService.findEnvironmentByCode(taskInstance.getEnvironmentCode());

Review Comment:
   greate is a more elegant solution，i think in baseSql add environment_config 
column will resolve the problem
   
![image](https://user-images.githubusercontent.com/5456361/175458093-176da91c-9e29-4fc7-8335-aa4fe003483f.png)
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to