guoshupei commented on PR #10618: URL: https://github.com/apache/dolphinscheduler/pull/10618#issuecomment-1166465387
> > > @guoshupei Please take a look. > > > > > > Okay, @ruanwenjun I agree with you. In addition, I think online or offline master, if it can not be reset `MASTER_SLOT` and `MASTER_SIZE`? WDYT? > > The reset `MASTER_SLOT` and `MASTER_SIZE` is also not an atomic operation, and each master may have their own time to do this operation, but this is not a problem, since we use database transaction to avoid the command be duplicated to consume. In most of time, the master can have a right slot and master size, but if they don't have the right slot, the ds can still work will. Yes, you are right, currently database transaction ensures that command can be consumed correctly and once. I just thought that when the master went online or offline, the active master that didn't get the zookeeper lock would stop working for a short time. And I don't think that's a problem.  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
