caishunfeng commented on code in PR #10624: URL: https://github.com/apache/dolphinscheduler/pull/10624#discussion_r907014504
########## dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/expand/TimePlaceholderResolverExpandServiceImpl.java: ########## @@ -0,0 +1,39 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.dolphinscheduler.common.expand; + +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; +import org.springframework.stereotype.Component; + +@Component +public class TimePlaceholderResolverExpandServiceImpl implements TimePlaceholderResolverExpandService { + + private static final Logger logger = LoggerFactory.getLogger(TimePlaceholderResolverExpandServiceImpl.class); + + @Override + public boolean timeFunctionNeedExpand(String placeholderName) { + return false; + } + + @Override + public String timeFunctionExtension(Integer processInstanceId, String timeZone, String placeholderName) { + logger.warn("time function external expansion"); Review Comment: remove if not use, and I think the log level is `debug` or `info`, not `warn`. ########## dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/ParameterUtils.java: ########## @@ -86,7 +89,7 @@ public static String convertParameterPlaceholders(String parameterString, Map<St * @param scheduleTime schedule time * @return curing user define parameters */ - public static String curingGlobalParams(Map<String, String> globalParamMap, List<Property> globalParamList, + public static String curingGlobalParams(Integer processInstanceId, Map<String, String> globalParamMap, List<Property> globalParamList, Review Comment: Please update the notes too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
