kezhenxu94 commented on code in PR #10364:
URL: https://github.com/apache/dolphinscheduler/pull/10364#discussion_r907336155
##########
.github/workflows/backend.yml:
##########
@@ -103,7 +106,8 @@ jobs:
- uses: actions/download-artifact@v2
name: Download Binary Package
with:
- name: binary-package
+ # Only run cluster test on jdk8
Review Comment:
Add an `if` condition to this step otherwise the job will be run twice on
jdk 8
##########
.github/workflows/backend.yml:
##########
@@ -56,6 +56,9 @@ jobs:
needs: paths-filter
if: ${{ (needs.paths-filter.outputs.not-ignore == 'true') ||
(github.event_name == 'push') }}
runs-on: ubuntu-latest
+ strategy:
+ matrix:
+ java: [ '8', '11' ]
Review Comment:
Add `setup-java` to this job otherwise this matrix does nothing but only
build the package twice on default jdk
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
