ruanwenjun commented on code in PR #10656:
URL: https://github.com/apache/dolphinscheduler/pull/10656#discussion_r908493690


##########
dolphinscheduler-task-plugin/dolphinscheduler-task-datax/src/main/java/org/apache/dolphinscheduler/plugin/task/datax/DataxTask.java:
##########
@@ -167,6 +167,7 @@ public void handle() throws Exception {
             setAppIds(commandExecuteResult.getAppIds());
             setProcessId(commandExecuteResult.getProcessId());
         } catch (Exception e) {
+            logger.error("datax task error", e);

Review Comment:
   In fact, the exception will be thrown to upper layer, and will log at the 
upper layer. I don't suggest we log the exception and throw it again, this will 
cause the exception occur multiple times in log.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to