guodongym commented on PR #10675: URL: https://github.com/apache/dolphinscheduler/pull/10675#issuecomment-1171358469
> > > I found this PR dulicated with #10676. @sketchmind @guodongym > > > > > > @SbloodyS The afternoon issue was assigned to me, so I developed it. After submit PR, I also found some duplication. If @sketchmind is willing to continue processing, I can scrap mine and change to Reviewer > > As a first time contributor in ds, I is willing to continue,but review your code, why retrun instead of throw exception if file exists when overwrite is false. Usually this mode is append, failed or overwrite in other projects If the file already exists and you do not select overwrite, the file is available and you do not need to throw an exception -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
