ruanwenjun commented on PR #9955:
URL: 
https://github.com/apache/dolphinscheduler/pull/9955#issuecomment-1173458089

   > I think it's necessary to use another thread to address the risk handling 
of the failed queue and the 3 second delay. but the biggest difference between 
the failure queue and the current solution is, To the greatest extent, when 
tasks with higher priority fail, the highest priority task will not be 
dispatched every time, and we can do some other expansion processing for these 
failed tasks relying on the failure queue, like monitor and more.
   > 
   > [#9955 
(comment)](https://github.com/apache/dolphinscheduler/pull/9955#issuecomment-1173316182)
   
   Ok, use a single thread to consume the failure queue looks good to me, and 
since you add a new status, you also need to add this to NEED_FAILOVER_STATES, 
and I am not sure if there is other place need to update.
   
   In the current process, the status change is easy to cause bug.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to