SbloodyS commented on code in PR #10670:
URL: https://github.com/apache/dolphinscheduler/pull/10670#discussion_r914380039
##########
dolphinscheduler-api-test/dolphinscheduler-api-test-case/src/test/java/org/apache/dolphinscheduler/api.test/cases/TenantAPITest.java:
##########
@@ -76,38 +76,9 @@ public void testCreateTenant() {
public void testDuplicateCreateTenant() {
TenantPage tenantPage = new TenantPage();
- HttpResponse createTenantHttpResponse =
tenantPage.createTenant(sessionId, tenant, 1, "");
+ HttpResponse createTenantHttpResponse =
tenantPage.createTenant(sessionId, tenantName, 1, "");
Assertions.assertFalse(createTenantHttpResponse.body().success());
}
- @Test
- @Order(5)
- public void testGetTenantListPaging() {
- TenantPage tenantPage = new TenantPage();
-
- HttpResponse createTenantHttpResponse =
tenantPage.getTenantListPaging(sessionId, 1, 10, "");
- boolean result = false;
-
- for (TenantListPagingResponseTotalList
tenantListPagingResponseTotalList :
JSONUtils.convertValue(createTenantHttpResponse.body().data(),
TenantListPagingResponseData.class).totalList()) {
- if (tenantListPagingResponseTotalList.tenantCode().equals(tenant))
{
- result = true;
- existTenantId = tenantListPagingResponseTotalList.id();
- break;
- }
- }
-
- Assertions.assertTrue(createTenantHttpResponse.body().success());
- Assertions.assertTrue(result);
- }
-
- @Test
- @Order(10)
- public void testDeleteTenant() {
- TenantPage tenantPage = new TenantPage();
-
- HttpResponse deleteTenantHttpResponse =
tenantPage.deleteTenant(sessionId, existTenantId);
-
- Assertions.assertTrue(deleteTenantHttpResponse.body().success());
- }
Review Comment:
> Is there any reason for why we need to delete these tests?
Currently checkstyle not enabled in api-test...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
