ruanwenjun commented on code in PR #10786:
URL: https://github.com/apache/dolphinscheduler/pull/10786#discussion_r914383008
##########
dolphinscheduler-worker/src/main/java/org/apache/dolphinscheduler/server/worker/processor/TaskExecuteResponseAckProcessor.java:
##########
@@ -58,7 +58,15 @@ public void process(Channel channel, Command command) {
if (taskExecuteResponseAckCommand.getStatus() ==
ExecutionStatus.SUCCESS.getCode()) {
ResponseCache.get().removeResponseCache(taskExecuteResponseAckCommand.getTaskInstanceId());
TaskCallbackService.remove(taskExecuteResponseAckCommand.getTaskInstanceId());
- logger.debug("remove REMOTE_CHANNELS, task instance id:{}",
taskExecuteResponseAckCommand.getTaskInstanceId());
+ if (logger.isDebugEnabled()) {
Review Comment:
Yes, it will check internally, but this judge can help to speed up this
judge, I will revert this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
