zhongjiajie commented on code in PR #10657:
URL: https://github.com/apache/dolphinscheduler/pull/10657#discussion_r915789726
##########
dolphinscheduler-task-plugin/dolphinscheduler-task-emr/src/main/java/org/apache/dolphinscheduler/plugin/task/emr/EmrParameters.java:
##########
@@ -52,10 +78,20 @@ public void setJobFlowDefineJson(String jobFlowDefineJson) {
this.jobFlowDefineJson = jobFlowDefineJson;
}
+ public String getStepsDefineJson() {
+ return stepsDefineJson;
+ }
+
+ public void setStepsDefineJson(String stepsDefineJson) {
+ this.stepsDefineJson = stepsDefineJson;
+ }
Review Comment:
currently we support lambok in our code base, could you use `@Data` instead
of getter or setter?
##########
docs/docs/en/guide/task/emr.md:
##########
@@ -19,11 +23,13 @@ Amazon EMR task type, for creating EMR clusters on AWS and
running computing tas
| Task priority | When the number of worker threads is insufficient, execute
in the order of priority from high to low, and tasks with the same priority
will execute in a first-in first-out order. |
| Worker grouping | Assign tasks to the machines of the worker group to
execute. If `Default` is selected, randomly select a worker machine for
execution. |
| Times of failed retry attempts | The number of times the task failed to
resubmit. You can select from drop-down or fill-in a number. |
-| Failed retry interval: The time interval for resubmitting the task after a
failed task. You can select from drop-down or fill-in a number. |
+| Failed retry interval | The time interval for resubmitting the task after a
failed task. You can select from drop-down or fill-in a number. |
| Timeout alarm | Check the timeout alarm and timeout failure. When the task
runs exceed the "timeout", an alarm email will send and the task execution will
fail. |
-| JSON | JSON corresponding to the
[RunJobFlowRequest](https://docs.aws.amazon.com/AWSJavaSDK/latest/javadoc/com/amazonaws/services/elasticmapreduce/model/RunJobFlowRequest.html)
object, for details refer to
[API_RunJobFlow_Examples](https://docs.aws.amazon.com/emr/latest/APIReference/API_RunJobFlow.html#API_RunJobFlow_Examples).
|
+| Program Type | Select the program type. If it is `RUN_JOB_FLOW`, you need to
fill in `jobFlowDefineJson`, if it is `ADD_JOB_FLOW_STEPS`, you need to fill in
`stepsDefineJson`. |
+| jobFlowDefineJson | JSON corresponding to the
[RunJobFlowRequest](https://docs.aws.amazon.com/AWSJavaSDK/latest/javadoc/com/amazonaws/services/elasticmapreduce/model/RunJobFlowRequest.html)
object, for details refer to
[API_RunJobFlow_Examples](https://docs.aws.amazon.com/emr/latest/APIReference/API_RunJobFlow.html#API_RunJobFlow_Examples).
|
+| stepsDefineJson | JSON corresponding to the
[AddJobFlowStepsRequest](https://docs.aws.amazon.com/AWSJavaSDK/latest/javadoc/com/amazonaws/services/elasticmapreduce/model/AddJobFlowStepsRequest.html)
object, for details refer to
[API_AddJobFlowSteps_Examples](https://docs.aws.amazon.com/emr/latest/APIReference/API_AddJobFlowSteps.html#API_AddJobFlowSteps_Examples).
|
Review Comment:
could you migreate these two type as child or `program type`? just like
`Deployment mode` in
https://github.com/apache/dolphinscheduler/blob/dev/docs/docs/en/guide/task/spark.md
?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
