SnowMoon-Dev commented on code in PR #10817: URL: https://github.com/apache/dolphinscheduler/pull/10817#discussion_r916143595
########## dolphinscheduler-api-test/dolphinscheduler-api-test-case/src/test/java/org/apache/dolphinscheduler/api.test/pages/login/form/LoginFormData.java: ########## @@ -0,0 +1,41 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + + +package org.apache.dolphinscheduler.api.test.pages.login.form; + +public enum LoginFormData { + USR_NAME("userName", "admin"), + USER_PASSWD("userPassword", "dolphinscheduler123"); + + LoginFormData(String param, String data) { + this.data = data; + this.param = param; + + } + + private final String param; + private final String data; + + public String getParam() { + return param; + } + + public String getData() { + return data; + } Review Comment: I tried to change it to lombok, but it showed that the serialization failed. This server interface request framework cannot integrate lombok. I think this lombok is not necessary. Although some boilerplate code is reduced, it is given by the newly integrated server interface request framework. In terms of convenience, these boilerplate codes are acceptable and written in line with the habits of current API developers, because API developers currently do not use Lombok ########## dolphinscheduler-api-test/dolphinscheduler-api-test-case/src/test/java/org/apache/dolphinscheduler/api.test/pages/security/tenant/entity/TenantResponseEntity.java: ########## @@ -0,0 +1,73 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.dolphinscheduler.api.test.pages.security.tenant.entity; + + +public class TenantResponseEntity extends TenantRequestEntity { Review Comment: I tried to change it to lombok, but it showed that the serialization failed. This server interface request framework cannot integrate lombok. I think this lombok is not necessary. Although some boilerplate code is reduced, it is given by the newly integrated server interface request framework. In terms of convenience, these boilerplate codes are acceptable and written in line with the habits of current API developers, because API developers currently do not use Lombok -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
