caishunfeng commented on code in PR #10839:
URL: https://github.com/apache/dolphinscheduler/pull/10839#discussion_r917213644
##########
dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteRunnable.java:
##########
@@ -899,6 +928,16 @@ private Optional<TaskInstance> submitTaskExec(TaskInstance
taskInstance) {
validTaskMap.put(taskInstance.getTaskCode(), taskInstance.getId());
taskInstanceMap.put(taskInstance.getId(), taskInstance);
activeTaskProcessorMaps.put(taskInstance.getTaskCode(),
taskProcessor);
+ // todo: do we need to check the result?
Review Comment:
Should remove this comment?
##########
dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessServiceImpl.java:
##########
@@ -276,6 +275,9 @@ public class ProcessServiceImpl implements ProcessService {
@Autowired
private CuringParamsService curingGlobalParamsService;
+ @Autowired
+ private ProcessService processService;
Review Comment:
Quote itself?
##########
dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteRunnable.java:
##########
@@ -784,45 +791,60 @@ private void initTaskQueue() throws
StateEventHandleException, CronParseExceptio
errorTaskMap.clear();
if (!isNewProcessInstance()) {
Review Comment:
It's better to extract a method
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
