EricGao888 opened a new issue, #10867:
URL: https://github.com/apache/dolphinscheduler/issues/10867

   ### Search before asking
   
   - [X] I had searched in the 
[issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and 
found no similar feature requirement.
   
   
   ### Description
   
   * Currently, as shown in 
https://dolphinscheduler.apache.org/en-us/docs/dev/user_doc/guide/metrics/metrics.html,
 we use metric names to indicate whether the related counter / timer is used 
for some failure or success. For example, we use 
`ds.workflow.instance.failure.count` to count failed workflow instances and 
`ds.workflow.instance.success.count` for succeeded workflow instances. 
   * However, it would be a better practice to indicate this kind of info in 
metric tags instead of names, as described in this 
[comment](https://github.com/apache/dolphinscheduler/pull/10749#discussion_r914435813).
   
   ### Are you willing to submit a PR?
   
   - [X] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of 
Conduct](https://www.apache.org/foundation/policies/conduct)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: 
[email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to