zhuangchong commented on PR #10869: URL: https://github.com/apache/dolphinscheduler/pull/10869#issuecomment-1179856270
@zhuxt2015 The original requirement is that the SQL task supports multi-stage SQL execution, for example, the requirement to execute multiple MySQL insert statements in one SQL task. I have a different opinion from you, and I do not recommend you to modify it in this way. From your PR, you provide a default delimiter in the code. This is no problem when using the MySQL data source, but when using the Hive data source, this delimiter is not needed, Hive itself supports executing multiple segmented statements at a time. The description of the document I provided is not clear. What I have implemented is 1. The data source that does not support the execution of multiple segmented statements at a time, and I want to execute multiple SQL tasks of multiple segmented statements at a time, at this time, I need to fill in this separator on the page, For example, MySQL, PG 2. Supports data sources that execute multiple segmented statements at a time, without input separators, like Hive I agree with what you said `Less is more`, I also think that this delimiter should not be filled in by the user, this parameter is related to the data source, I have expressed my thoughts in PR #9917, if you have time consider implementing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
