SbloodyS commented on code in PR #10876:
URL: https://github.com/apache/dolphinscheduler/pull/10876#discussion_r917488217
##########
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/DataSourceController.java:
##########
@@ -339,7 +339,7 @@ public Result authedDatasource(@ApiIgnore
@RequestAttribute(value = Constants.SE
@AccessLogAnnotation(ignoreRequestArgs = "loginUser")
public Result getKerberosStartupState(@ApiIgnore @RequestAttribute(value =
Constants.SESSION_USER) User loginUser) {
// if upload resource is HDFS and kerberos startup is true , else false
- return success(Status.SUCCESS.getMsg(),
CommonUtils.getKerberosStartupState());
+ return success(Status.SUCCESS.getMsg(), true);
Review Comment:
The parameter `principal` and `KerberosStartupState` are strongly
correlated. I don't think this needs to be modified. We should add a
description to the document to tell users this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
