ruanwenjun commented on code in PR #10875: URL: https://github.com/apache/dolphinscheduler/pull/10875#discussion_r917511539
########## dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/service/ExecutingService.java: ########## @@ -0,0 +1,74 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.dolphinscheduler.server.master.service; + +import org.apache.dolphinscheduler.dao.entity.TaskInstance; +import org.apache.dolphinscheduler.remote.dto.TaskInstanceExecuteDto; +import org.apache.dolphinscheduler.remote.dto.WorkflowExecuteDto; +import org.apache.dolphinscheduler.server.master.cache.ProcessInstanceExecCacheManager; +import org.apache.dolphinscheduler.server.master.controller.WorkflowExecuteController; +import org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteRunnable; + +import org.apache.commons.beanutils.BeanUtils; +import org.apache.commons.collections4.CollectionUtils; +import org.apache.commons.compress.utils.Lists; + +import java.lang.reflect.InvocationTargetException; +import java.util.List; + +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; +import org.springframework.beans.factory.annotation.Autowired; +import org.springframework.stereotype.Component; + +/** + * executing service, to query executing data from memory, such workflow instance + */ +@Component +public class ExecutingService { + + private static final Logger logger = LoggerFactory.getLogger(WorkflowExecuteController.class); + + @Autowired + private ProcessInstanceExecCacheManager processInstanceExecCacheManager; + + public WorkflowExecuteDto queryWorkflowExecutingData(Integer processInstanceId) { + WorkflowExecuteRunnable workflowExecuteRunnable = processInstanceExecCacheManager.getByProcessInstanceId(processInstanceId); + if (workflowExecuteRunnable == null) { + logger.info("workflow execute data not found, maybe it has finished, workflow id:{}", processInstanceId); + return null; + } + try { + WorkflowExecuteDto workflowExecuteDto = new WorkflowExecuteDto(); + BeanUtils.copyProperties(workflowExecuteDto, workflowExecuteRunnable.getProcessInstance()); Review Comment: OK, did you try the BeanUtils can work well on ProcessInstance? And in my know ledge, The first param is source, the second param is target ```suggestion BeanUtils.copyProperties(workflowExecuteRunnable.getProcessInstance(), workflowExecuteDto); ``` ########## dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/service/ExecutingService.java: ########## @@ -0,0 +1,74 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.dolphinscheduler.server.master.service; + +import org.apache.dolphinscheduler.dao.entity.TaskInstance; +import org.apache.dolphinscheduler.remote.dto.TaskInstanceExecuteDto; +import org.apache.dolphinscheduler.remote.dto.WorkflowExecuteDto; +import org.apache.dolphinscheduler.server.master.cache.ProcessInstanceExecCacheManager; +import org.apache.dolphinscheduler.server.master.controller.WorkflowExecuteController; +import org.apache.dolphinscheduler.server.master.runner.WorkflowExecuteRunnable; + +import org.apache.commons.beanutils.BeanUtils; +import org.apache.commons.collections4.CollectionUtils; +import org.apache.commons.compress.utils.Lists; + +import java.lang.reflect.InvocationTargetException; +import java.util.List; + +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; +import org.springframework.beans.factory.annotation.Autowired; +import org.springframework.stereotype.Component; + +/** + * executing service, to query executing data from memory, such workflow instance + */ +@Component +public class ExecutingService { + + private static final Logger logger = LoggerFactory.getLogger(WorkflowExecuteController.class); + + @Autowired + private ProcessInstanceExecCacheManager processInstanceExecCacheManager; + + public WorkflowExecuteDto queryWorkflowExecutingData(Integer processInstanceId) { + WorkflowExecuteRunnable workflowExecuteRunnable = processInstanceExecCacheManager.getByProcessInstanceId(processInstanceId); + if (workflowExecuteRunnable == null) { + logger.info("workflow execute data not found, maybe it has finished, workflow id:{}", processInstanceId); + return null; + } + try { + WorkflowExecuteDto workflowExecuteDto = new WorkflowExecuteDto(); + BeanUtils.copyProperties(workflowExecuteDto, workflowExecuteRunnable.getProcessInstance()); Review Comment: OK, did you try the BeanUtils can work well on ProcessInstance? And in my knowledge, The first param is source, the second param is target ```suggestion BeanUtils.copyProperties(workflowExecuteRunnable.getProcessInstance(), workflowExecuteDto); ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
