zhongjiajie commented on PR #10823: URL: https://github.com/apache/dolphinscheduler/pull/10823#issuecomment-1180515884
BTW, I have review comment in https://github.com/apache/dolphinscheduler/pull/10823#discussion_r917614946. I think maybe we should better add a new interface named `createOrUpdateResource` in `ResourcesService.java`, just like you add `onlineCreateOrUpdateResourceWithDir` to `ResourcesService.java`. And in `PythonGateway.java` we just add code below code to keep it as simple as possible, WDYT? ```java public Integer createOrUpdateResource( String userName, String fullName, String description, String resourceContent) { return resourceService.createOrUpdateResource(userName, fullName, description, resourceContent); } ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
