ruanwenjun commented on PR #10886: URL: https://github.com/apache/dolphinscheduler/pull/10886#issuecomment-1181221239
> Hi @ruanwenjun I found many changes in this pr is about `command to message`, is it necessary to change it? > I think we can keep the command name to reduce modification and cherry-pick costs, WDYT? I add a new class `BaseMessage`, and our async command will extend this class, to get some fields. I suggestion to rename command to message, since we already have a Command, and the other class is only command body. Anyway, I will rollback the rename change, but I suggest we can do this change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
