caishunfeng commented on code in PR #10834:
URL: https://github.com/apache/dolphinscheduler/pull/10834#discussion_r920846039
##########
dolphinscheduler-dao/src/main/resources/org/apache/dolphinscheduler/dao/mapper/ProjectMapper.xml:
##########
@@ -162,22 +162,25 @@
<select id="queryAllProject"
resultType="org.apache.dolphinscheduler.dao.entity.Project">
select
- <include refid="baseSql"/>
- from t_ds_project
- where 1=1
+ <include refid="baseSqlV2">
+ <property name="alias" value="p"/>
+ </include>
+ from t_ds_project p
<if test="userId != 0">
- and user_id = #{userId}
+ right join t_ds_relation_project_user rpu on p.id = rpu.project_id
+ where rpu.user_id = #{userId}
</if>
</select>
<select id="listAuthorizedProjects"
resultType="org.apache.dolphinscheduler.dao.entity.Project">
select
- <include refid="baseSql"/>
- from t_ds_project dp
- where 1=1
+ <include refid="baseSqlV2">
+ <property name="alias" value="p"/>
+ </include>
+ from t_ds_project p
<if test="userId != 0">
- and dp.id in (select project_id from t_ds_relation_project_user
where user_id=#{userId}
- union select id as project_id from t_ds_project where
user_id=#{userId})
+ right join t_ds_relation_project_user rpu on p.id = rpu.project_id
+ where tdrpu.user_id = #{userId}
Review Comment:
```suggestion
where rpu.user_id = #{userId}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
