kezhenxu94 commented on code in PR #10981: URL: https://github.com/apache/dolphinscheduler/pull/10981#discussion_r921744266
########## dolphinscheduler-registry/dolphinscheduler-registry-plugins/dolphinscheduler-registry-etcd/pom.xml: ########## @@ -0,0 +1,43 @@ +<?xml version="1.0" encoding="UTF-8"?> +<project xmlns="http://maven.apache.org/POM/4.0.0"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> + <parent> + <artifactId>dolphinscheduler-registry-plugins</artifactId> + <groupId>org.apache.dolphinscheduler</groupId> + <version>dev-SNAPSHOT</version> + </parent> + <modelVersion>4.0.0</modelVersion> + + <artifactId>dolphinscheduler-registry-etcd</artifactId> + + <properties> + <maven.compiler.source>8</maven.compiler.source> + <maven.compiler.target>8</maven.compiler.target> + </properties> + + <dependencies> + <dependency> + <groupId>org.apache.dolphinscheduler</groupId> + <artifactId>dolphinscheduler-registry-api</artifactId> + </dependency> + <dependency> + <groupId>org.apache.dolphinscheduler</groupId> + <artifactId>dolphinscheduler-common</artifactId> + </dependency> + <dependency> + <groupId>io.etcd</groupId> + <artifactId>jetcd-core</artifactId> + </dependency> + + <dependency> + <groupId>io.etcd</groupId> + <artifactId>jetcd-test</artifactId> + </dependency> Review Comment: This should be `test` scope ########## dolphinscheduler-registry/dolphinscheduler-registry-plugins/dolphinscheduler-registry-etcd/pom.xml: ########## @@ -0,0 +1,43 @@ +<?xml version="1.0" encoding="UTF-8"?> +<project xmlns="http://maven.apache.org/POM/4.0.0"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> + <parent> + <artifactId>dolphinscheduler-registry-plugins</artifactId> + <groupId>org.apache.dolphinscheduler</groupId> + <version>dev-SNAPSHOT</version> + </parent> + <modelVersion>4.0.0</modelVersion> + + <artifactId>dolphinscheduler-registry-etcd</artifactId> + + <properties> + <maven.compiler.source>8</maven.compiler.source> + <maven.compiler.target>8</maven.compiler.target> + </properties> Review Comment: Don't set this here ########## dolphinscheduler-registry/dolphinscheduler-registry-plugins/dolphinscheduler-registry-etcd/src/main/java/org/apache/dolphinscheduler/plugin/registry/etcd/EtcdRegistryProperties.java: ########## @@ -0,0 +1,31 @@ +package org.apache.dolphinscheduler.plugin.registry.etcd; + +import lombok.Data; +import org.springframework.boot.autoconfigure.condition.ConditionalOnProperty; +import org.springframework.boot.context.properties.ConfigurationProperties; +import org.springframework.context.annotation.Configuration; + +import java.time.Duration; + +@Data +@Configuration +@ConditionalOnProperty(prefix = "registry", name = "type", havingValue = "etcd") +@ConfigurationProperties(prefix = "registry") +public class EtcdRegistryProperties { + private String endpoints; + private String namespace="dolphinscheduler"; + private Duration connectionTimeout = Duration.ofSeconds(9); + + // auth + private String user; + private String password; + private String authority; + + // RetryPolicy + private Long retryDelay=60L; + private Long retryMaxDelay=300L; + private Duration retryMaxDuration=Duration.ofMillis(1500);; Review Comment: ```suggestion private Duration retryMaxDuration=Duration.ofMillis(1500); ``` ########## dolphinscheduler-registry/dolphinscheduler-registry-plugins/dolphinscheduler-registry-etcd/src/main/java/org/apache/dolphinscheduler/plugin/registry/etcd/EtcdRegistryProperties.java: ########## @@ -0,0 +1,31 @@ +package org.apache.dolphinscheduler.plugin.registry.etcd; + +import lombok.Data; +import org.springframework.boot.autoconfigure.condition.ConditionalOnProperty; +import org.springframework.boot.context.properties.ConfigurationProperties; +import org.springframework.context.annotation.Configuration; + +import java.time.Duration; + +@Data +@Configuration +@ConditionalOnProperty(prefix = "registry", name = "type", havingValue = "etcd") +@ConfigurationProperties(prefix = "registry") +public class EtcdRegistryProperties { + private String endpoints; + private String namespace="dolphinscheduler"; + private Duration connectionTimeout = Duration.ofSeconds(9); + + // auth + private String user; + private String password; + private String authority; + + // RetryPolicy + private Long retryDelay=60L; + private Long retryMaxDelay=300L; Review Comment: Consider also using `Duration` type, and format the codes please. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
