ruanwenjun commented on code in PR #11009:
URL: https://github.com/apache/dolphinscheduler/pull/11009#discussion_r922693117
##########
dolphinscheduler-master/src/test/java/org/apache/dolphinscheduler/server/master/processor/TaskAckProcessorTest.java:
##########
@@ -66,7 +65,7 @@ public void before() {
taskExecuteRunningMessage = new
TaskExecuteRunningCommand("127.0.0.1:5678",
"
127.0.0.1:1234",
System.currentTimeMillis());
- taskExecuteRunningMessage.setStatus(1);
+ taskExecuteRunningMessage.setStatus(ExecutionStatus.SUBMITTED_SUCCESS);
Review Comment:
```suggestion
taskExecuteRunningMessage.setStatus(ExecutionStatus.RUNNING_EXECUTION);
```
##########
dolphinscheduler-remote/src/main/java/org/apache/dolphinscheduler/remote/command/StateEventResponseCommand.java:
##########
@@ -71,7 +72,7 @@ public Command convert2Command() {
public String toString() {
return "StateEventResponseCommand{"
+ "key=" + key
- + ", status=" + status
+ + ", status=" + status.getDescp()
Review Comment:
```suggestion
+ ", status=" + status
```
##########
dolphinscheduler-remote/src/main/java/org/apache/dolphinscheduler/remote/command/TaskExecuteRunningAckMessage.java:
##########
@@ -70,6 +71,6 @@ public Command convert2Command() {
@Override
public String toString() {
- return "TaskExecuteRunningAckCommand{" + "taskInstanceId=" +
taskInstanceId + ", status=" + status + '}';
+ return "TaskExecuteRunningAckCommand{" + "taskInstanceId=" +
taskInstanceId + ", status=" + status.getDescp() + '}';
Review Comment:
```suggestion
return "TaskExecuteRunningAckCommand{" + "taskInstanceId=" +
taskInstanceId + ", status=" + status + '}';
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
