SbloodyS commented on PR #11011:
URL: 
https://github.com/apache/dolphinscheduler/pull/11011#issuecomment-1186399335

   > Hi @SbloodyS, could you please take several minuates to review the code? 
Almost finished, one thing left to be confirmed:
   > 
   > I notice there's a folder 
https://github.com/apache/dolphinscheduler/tree/dev/dolphinscheduler-dao/src/main/resources/sql/upgrade,
 with lots of subfolders inside (e.g. `2.0.4_schema`), does that means these 
will be excuted when a user, with 2.0.4 installed, trying to upgrade dolphin to 
the latest release?
   > 
   > If so, I think every files in this folder need add one line to alter the 
alert group table to add one additional column.
   
   Is it appropriate to put it in 3.1.0? @zhongjiajie @caishunfeng 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to