ruanwenjun commented on issue #10918: URL: https://github.com/apache/dolphinscheduler/issues/10918#issuecomment-1193065086
> > I just see the latest code, we didn't use connection pool in SQL task, so the hikari pool config isn't used for SQL task. > > Right now, for each task we will create a new connection and will close this connection after finished. I am not clear if we need to use connection pool in SQL task. > > cc @caishunfeng @SbloodyS > > @ruanwenjun hello, we create HikariDataSource pool indeed, and you can test on SQL task with mysql datasource connection, you will see log "Creating HikariDataSource pool for maxActive" in worker-server log which is present in JDBCDataSourceProvider.java file. This is due to we rely on dao module, but the `HikariDataSource` will not work for SQL task. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
