EricGao888 commented on code in PR #11128:
URL: https://github.com/apache/dolphinscheduler/pull/11128#discussion_r928806694
##########
dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/metrics/ProcessInstanceMetrics.java:
##########
@@ -31,6 +36,24 @@ private ProcessInstanceMetrics() {
throw new UnsupportedOperationException("Utility class");
}
+ private static Map<String, Counter> PROCESS_INSTANCE_COUNTERS = new
HashMap<>();
+
+ private static final Set<String> PROCESS_INSTANCE_STATES = ImmutableSet.of(
+ "submit", "timeout", "finish", "failover", "success", "fail",
"stop");
Review Comment:
@ruanwenjun Hi I just checked this file
https://github.com/apache/dolphinscheduler/blob/011040f90edd3afffd286a98cbef550c2c90d7d7/dolphinscheduler-task-plugin/dolphinscheduler-task-api/src/main/java/org/apache/dolphinscheduler/plugin/task/api/enums/ExecutionStatus.java#L27-L68
It seems those states in workflow metrics and task metrics are not fully
covered by `ExecutionStatus` e.g. `failover` and `finish`. What about keeping
it this way for consistency and easier intelligibility?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
