EricGao888 commented on issue #11074: URL: https://github.com/apache/dolphinscheduler/issues/11074#issuecomment-1195268802
> We might need some discussions here. Currently there are two potential methods to avoid `sonar` failing for UT coverage decrease caused by `@Data`: > > 1. Use the method described in this issue. > 2. Keep `@Data` and fix `sonar` instead to exclude code generated by `lombok` > > See: [#11133 (comment)](https://github.com/apache/dolphinscheduler/pull/11133#issuecomment-1195168073) > > related: #11133 I don't have strong opinions here about which method to take, as long as we stick to one of them to keep consistency. If we agree on taking the second one, we need to fix `sonar` in this issue instead of adding docs and changing CI. WDYT @SbloodyS @kezhenxu94 @rickchengx -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
