WangJPLeo commented on code in PR #11141:
URL: https://github.com/apache/dolphinscheduler/pull/11141#discussion_r930828428
##########
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/permission/ResourcePermissionCheckService.java:
##########
@@ -51,7 +51,7 @@
* @param logger
* @return
*/
- boolean operationPermissionCheck(Object authorizationType, Integer userId,
String permissionKey, Logger logger);
+ boolean operationPermissionCheck(Object authorizationType, Object[]
projectIds, Integer userId, String permissionKey, Logger logger);
Review Comment:
This is a good idea. There is an intermediate layer responsible for the
assembly of parameters when the business logic calls this method. In fact,
there is no need to change the business logic, but the workload is concentrated
in the Mock.when of the unit test.
Afterwards, a Base will be extracted for the permission Mock.when involved
in the unit test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
