HeZean commented on PR #11011: URL: https://github.com/apache/dolphinscheduler/pull/11011#issuecomment-1197112762
> > In fact, I don't think `Fault tolerance warning` should belong to AlertGroup, these should control by `WorkflowInstance` and `TaskInstance`? > > BTW, I find this PR is related to the `server` down receiver, not `Fault tolerance` receiver, so please change the title to `Server down warning`. I'm getting quite confused with these two concepts, as I searched the repo, I consider `Fault tolerance warning ~= Server down warning`? see: https://github.com/apache/dolphinscheduler/blob/d80cf21456265c9d84e642bdb4db4067c7577fc6/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/AlertDao.java#L145-L157 Also, I didn't see an alert type 'server down', please correct me if I'm getting wrong. https://github.com/apache/dolphinscheduler/blob/fb0139e959d66b7531ee8d075c44cc5d1bd36c85/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/enums/AlertType.java#L25-L37 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
