zhongjiajie commented on code in PR #10621:
URL: https://github.com/apache/dolphinscheduler/pull/10621#discussion_r931979106


##########
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/ProcessDefinitionServiceImpl.java:
##########
@@ -1876,6 +1878,27 @@ protected void doBatchOperateProcessDefinition(User 
loginUser,
         }
     }
 
+    /**
+     * get new Task name or Process name when copy or import operate
+     * @param originalName Task or Process original name
+     * @param suffix "_copy_" or "_import_"
+     * @return
+     */
+    private String getNewName(String originalName, String suffix) {

Review Comment:
   can we add some test for test function? maybe we can test the public 
function use it.
   BTW, how about the process definition contain `_copy_` or `_import_` in the 
name? like `wf_copy_all_ods_data_to_dw`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to