caishunfeng commented on code in PR #11033:
URL: https://github.com/apache/dolphinscheduler/pull/11033#discussion_r932851718
##########
dolphinscheduler-alert/dolphinscheduler-alert-server/src/main/java/org/apache/dolphinscheduler/alert/AlertSenderService.java:
##########
@@ -92,6 +99,19 @@ public void send(List<Alert> alerts) {
alertDao.updateAlert(AlertStatus.EXECUTION_FAILURE, "no bind
plugin instance", alertId);
continue;
}
+
+ if (StringUtils.isNotEmpty(alert.getContent())) {
Review Comment:
BTW, had you found which alert type and content will cause this issue?
##########
dolphinscheduler-alert/dolphinscheduler-alert-server/src/main/java/org/apache/dolphinscheduler/alert/AlertSenderService.java:
##########
@@ -92,6 +99,19 @@ public void send(List<Alert> alerts) {
alertDao.updateAlert(AlertStatus.EXECUTION_FAILURE, "no bind
plugin instance", alertId);
continue;
}
+
+ if (StringUtils.isNotEmpty(alert.getContent())) {
Review Comment:
I found the issue is just about email, but if change the content here, will
take affect to all alert type, it's better to put before the email handle
content, WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
