MichaelDeSteven commented on PR #11180: URL: https://github.com/apache/dolphinscheduler/pull/11180#issuecomment-1202111911
> > > I haven't seen any v2 controller in this PR. Is there something missing? @MichaelDeSteven > > > > > > @SbloodyS the refactor work is so huge. I want to split the refactor task as small as possible. Hoping this way can make refactor task going well. this pr is first step. After that, I will continue v2 controller task. > > So we split the refactor task to a single function. Each pr should contain at least one refactor function and its related modifications. It is not recommended to submit irrelevant things in advance. how about this, I will add some interface in v2 controller base on this pr. after the pr is merged, I will continue finish pr #11148？ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
