Radeity commented on PR #11224: URL: https://github.com/apache/dolphinscheduler/pull/11224#issuecomment-1202302102
@microeastcowboy @zhuangchong Hi, I don't think it's a good fix. This code only considers the situation when a yarn job is done and collect its appId. However, when killing a running yarn job, there will be a remote network call to get all logs in `LogClientService`. If log size is large, this method maybe not a good solution. In addition, I'm working on a new way to handle this which replace current way to collect appIds, and I am willing to submit a PR when I finish it! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
