caishunfeng commented on code in PR #11254:
URL: https://github.com/apache/dolphinscheduler/pull/11254#discussion_r936286448
##########
dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessServiceImpl.java:
##########
@@ -2984,40 +2986,41 @@ public void releaseAllTaskGroup(int processInstanceId) {
@Override
public TaskInstance releaseTaskGroup(TaskInstance taskInstance) {
- TaskGroup taskGroup =
taskGroupMapper.selectById(taskInstance.getTaskGroupId());
- if (taskGroup == null) {
- return null;
- }
- TaskGroupQueue thisTaskGroupQueue =
this.taskGroupQueueMapper.queryByTaskId(taskInstance.getId());
- if (thisTaskGroupQueue.getStatus() == TaskGroupQueueStatus.RELEASE) {
- return null;
- }
+ TaskGroup taskGroup;
+ TaskGroupQueue thisTaskGroupQueue;
try {
- while (thisTaskGroupQueue.getForceStart() == Flag.NO.getCode() &&
taskGroupMapper.releaseTaskGroupResource(taskGroup.getId(),
taskGroup.getUseSize()
- , thisTaskGroupQueue.getId(),
TaskGroupQueueStatus.ACQUIRE_SUCCESS.getCode()) != 1) {
+ do {
+ taskGroup =
taskGroupMapper.selectById(taskInstance.getTaskGroupId());
Review Comment:
Is it necessary to query task group looply?
##########
dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessServiceImpl.java:
##########
@@ -2965,7 +2967,7 @@ public boolean robTaskGroupResouce(TaskGroupQueue
taskGroupQueue) {
@Override
public boolean acquireTaskGroupAgain(TaskGroupQueue taskGroupQueue) {
- return robTaskGroupResouce(taskGroupQueue);
+ return robTaskGroupResource(taskGroupQueue);
Review Comment:
I think the method `acquireTaskGroupAgain` can be removed and use
`robTaskGroupResouce` directly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
