EricGao888 commented on issue #11347: URL: https://github.com/apache/dolphinscheduler/issues/11347#issuecomment-1207797706
> Maybe you can see the pre-commit project https://pre-commit.com. But I have had some bad experiences with it, such as: > > * Slow: Obviously, because we have to check locally > * Update: when `pre-commit-config` file change, development have to update the pre-commit hook, otherwise they will failed in the github action. Also developer have to update both github action and `pre-commit-config` when then change the check rule Thanks for the information. I agree with that we should not have too many checks in `pre-commit hook` to avoid it getting too slow. Currently our `pre-commit hook` takes about 1 minute in totally to run `mvn spotless:apply` and I think it's fine. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
