ruanwenjun commented on PR #11332: URL: https://github.com/apache/dolphinscheduler/pull/11332#issuecomment-1210550244
> BTW, there are two ways to fully migrate those tests from jUnit 4 to jUnit 5: > > 1. We keep both versions of jUnit dependencies and migrate those UTs gradually with `DSIP-10` [[DSIP-10][Unit Tests] Improve DolphinScheduler unit tests #10573](https://github.com/apache/dolphinscheduler/issues/10573). > 2. Remove the dependency of jUnit 4 and migrate all the UTs with IDE `inspections` in this PR. > > However, I think the second method is a bit risky. > > WDYT? @caishunfeng @kezhenxu94 @SbloodyS @ruanwenjun I prefer the second way. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
