Amy0104 commented on PR #11203: URL: https://github.com/apache/dolphinscheduler/pull/11203#issuecomment-1212745381
> > It’s better to reuse the upload logic instead of creating a new reupload. Because if the upload logic has changed, the reupload need to be changed too. There will be a bug in the feature.BTW, you can format your code by eslint. > > I thought about it again, let's imagine a very possible change, if uploading files later supports batch uploading or uploading folders, it may lead to bugs in re-uploading, and if processed separately, the function of re-uploading files uses different front-end code and different interface, it will not affect. Of course, this can also use only one logic, and then patch the logic according to the parameters. If do this, does UDF resource upload also need to use this logic? The similarity reaches nearly eighty percent. I think it's better to reuse and handle the differences by parameters. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
