ruanwenjun commented on code in PR #11464:
URL: https://github.com/apache/dolphinscheduler/pull/11464#discussion_r945221437
##########
dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/consumer/TaskPriorityQueueConsumer.java:
##########
@@ -151,6 +173,10 @@ public List<TaskPriority> batchDispatch(int fetchTaskNum)
throws TaskPriorityQue
List<TaskPriority> failedDispatchTasks =
Collections.synchronizedList(new ArrayList<>());
CountDownLatch latch = new CountDownLatch(fetchTaskNum);
+ if (!taskDispatchFailedQueue.isEmpty()) {
+ consumerThreadPoolExecutor.submit(() ->
dispatchFailedBackToTaskPriorityQueue(fetchTaskNum));
+ }
Review Comment:
It's not good idea to consume the failed queue in the normal process.
BTW, this will cause the thread busy, you didn't wait the current batch task
finished.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
